Fix upgrade failure

   * Always commit even on SQL failure, this will Fix onUpgrade being call more that one time

Author: Jeasmine

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignalDbHelper.java

@@ -281,9 +281,10 @@ private static void upgradeOutcomeTableRevision1To2(SQLiteDatabase db) {
          //   3.12.1 quickly replaced 3.12.0 so converting cache isn't critical.
          db.execSQL("INSERT INTO outcome (" + commonColumns + ", weight) SELECT " + commonColumns + ", 0 FROM outcome_backup;");
          db.execSQL("DROP TABLE outcome_backup;");
-         db.execSQL("COMMIT;");
       } catch (SQLiteException e) {
          e.printStackTrace();
+      } finally {
+         db.execSQL("COMMIT;");
       }
    }
 

OneSignalSDK/onesignal/src/main/java/com/onesignal/outcomes/OSOutcomeTableProvider.java

@@ -70,9 +70,10 @@ public void upgradeOutcomeTableRevision2To3(SQLiteDatabase db) {
             db.execSQL("INSERT INTO " + OutcomeEventsTable.TABLE_NAME + "(" + commonColumnsWithNewSessionColumn + ")" +
                     " SELECT " + commonColumnsWithSessionColumn + " FROM " + auxOutcomeTableName + ";");
             db.execSQL("DROP TABLE " + auxOutcomeTableName + ";");
-            db.execSQL("COMMIT;");
         } catch (SQLiteException e) {
             e.printStackTrace();
+        } finally {
+            db.execSQL("COMMIT;");
         }
     }
 
@@ -103,9 +104,10 @@ public void upgradeCacheOutcomeTableRevision1To2(SQLiteDatabase db) {
             db.execSQL("UPDATE " + CachedUniqueOutcomeTable.TABLE_NAME +
                     " SET " + CachedUniqueOutcomeTable.COLUMN_CHANNEL_TYPE + " = \'" + OSInfluenceChannel.NOTIFICATION.toString() + "\';");
             db.execSQL("DROP TABLE " + oldCacheUniqueOutcomeTable + ";");
-            db.execSQL("COMMIT;");
         } catch (SQLiteException e) {
             e.printStackTrace();
+        } finally {
+            db.execSQL("COMMIT;");
         }
     }