Fix DIRECT IAM influence being cache

   * IAM Direct influence shoudn't be cache because DIRECT Influence will be only while the IAM is being display
   * Instead of caching DIRECT cache INDIRECT

Author: Jeasmine

OneSignalSDK/onesignal/src/main/java/com/onesignal/influence/OSInAppMessageTracker.java

@@ -95,6 +95,10 @@ void addSessionData(@NonNull JSONObject jsonObject, OSInfluence influence) {
 
     @Override
     public void cacheState() {
-        dataRepository.cacheIAMInfluenceType(influenceType == null ? OSInfluenceType.UNATTRIBUTED : influenceType);
+        // We only need to cache INDIRECT and UNATTRIBUTED influence types
+        // DIRECT is downgrade to INDIRECT to avoid inconsistency state
+        // where the app might be close before dismissing current displayed IAM
+        OSInfluenceType influenceTypeToCache = influenceType == null ? OSInfluenceType.UNATTRIBUTED : influenceType;
+        dataRepository.cacheIAMInfluenceType(influenceTypeToCache == OSInfluenceType.DIRECT ? OSInfluenceType.INDIRECT : influenceTypeToCache);
     }
 }

OneSignalSDK/unittest/src/test/java/com/test/onesignal/OutcomeEventV2UnitTests.java

@@ -43,6 +43,7 @@
 import com.onesignal.StaticResetHelper;
 import com.onesignal.influence.OSTrackerFactory;
 import com.onesignal.influence.model.OSInfluence;
+import com.onesignal.influence.model.OSInfluenceType;
 import com.onesignal.outcomes.OSOutcomeEventsFactory;
 import com.onesignal.outcomes.domain.OSOutcomeEventsRepository;
 import com.onesignal.outcomes.model.OSOutcomeEventParams;
@@ -342,6 +343,31 @@ public void testDirectOutcomeWithValueSuccess() throws Exception {
         assertEquals("{\"id\":\"testing\",\"sources\":{\"direct\":{\"notification_ids\":[\"notification_id\"],\"in_app_message_ids\":[\"iam_id\"]}},\"weight\":1.1,\"device_type\":1}", service.getLastJsonObjectSent());
     }
 
+    @Test
+    public void testDirectOutcomeSaveIndirectSuccess() throws Exception {
+        service.setSuccess(true);
+        sessionManager.initSessionFromCache();
+        sessionManager.onNotificationReceived(NOTIFICATION_ID);
+        sessionManager.onInAppMessageReceived(IAM_ID);
+        // Set DIRECT notification id influence
+        sessionManager.onDirectInfluenceFromNotificationOpen(NOTIFICATION_ID);
+        sessionManager.onDirectInfluenceFromIAMClick(IAM_ID);
+
+        controller.sendOutcomeEventWithValue(OUTCOME_NAME, 1.1f);
+        threadAndTaskWait();
+
+        handler.setOutcomes(repository.getSavedOutcomeEvents());
+
+        threadAndTaskWait();
+        assertEquals(0, outcomeEvents.size());
+        assertEquals("{\"id\":\"testing\",\"sources\":{\"direct\":{\"notification_ids\":[\"notification_id\"],\"in_app_message_ids\":[\"iam_id\"]}},\"weight\":1.1,\"device_type\":1}", service.getLastJsonObjectSent());
+
+        sessionManager.initSessionFromCache();
+        assertEquals(OSInfluenceType.INDIRECT, trackerFactory.getIAMChannelTracker().getInfluenceType());
+        assertEquals(1, trackerFactory.getIAMChannelTracker().getIndirectIds().length());
+        assertEquals(IAM_ID, trackerFactory.getIAMChannelTracker().getIndirectIds().get(0));
+    }
+
     @Test
     public void testIndirectOutcomeWithValueSuccess() throws Exception {
         service.setSuccess(true);