Merge pull request #1493 from syrepoman/main

Fix Android 4.4 and older devices fail to register to onesignal.com

Author: jkasten2

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignalRestClient.java

@@ -43,6 +43,8 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
+import javax.net.ssl.HttpsURLConnection;
+
 class OneSignalRestClient {
    static abstract class ResponseHandler {
       void onSuccess(String response) {}
@@ -143,6 +145,13 @@ private static Thread startHTTPConnection(String url, String method, JSONObject
          OneSignal.Log(OneSignal.LOG_LEVEL.DEBUG, "OneSignalRestClient: Making request to: " + BASE_URL + url);
          con = newHttpURLConnection(url);
 
+         // https://github.com/OneSignal/OneSignal-Android-SDK/issues/1465
+         // Android 4.4 and older devices fail to register to onesignal.com to due it's TLS1.2+ requirement
+         if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP_MR1 && con instanceof HttpsURLConnection) {
+            HttpsURLConnection conHttps = (HttpsURLConnection) con;
+            conHttps.setSSLSocketFactory(new TLS12SocketFactory(conHttps.getSSLSocketFactory()));
+         }
+
          con.setUseCaches(false);
          con.setConnectTimeout(timeout);
          con.setReadTimeout(timeout);

OneSignalSDK/onesignal/src/main/java/com/onesignal/TLS12SocketFactory.java

@@ -0,0 +1,64 @@
+package com.onesignal;
+
+import java.io.IOException;
+import java.net.InetAddress;
+import java.net.Socket;
+
+import javax.net.ssl.SSLSocket;
+import javax.net.ssl.SSLSocketFactory;
+
+public class TLS12SocketFactory extends SSLSocketFactory {
+    SSLSocketFactory sslSocketFactory;
+
+    public TLS12SocketFactory(SSLSocketFactory sslSocketFactory) {
+        super();
+        this.sslSocketFactory = sslSocketFactory;
+    }
+
+    @Override
+    public String[] getDefaultCipherSuites() {
+        return sslSocketFactory.getDefaultCipherSuites();
+    }
+
+    @Override
+    public String[] getSupportedCipherSuites() {
+        return sslSocketFactory.getSupportedCipherSuites();
+    }
+
+    @Override
+    public Socket createSocket() throws IOException {
+        return enableTLS(sslSocketFactory.createSocket());
+    }
+
+    @Override
+    public Socket createSocket(Socket s, String host, int port, boolean autoClose) throws IOException {
+        return enableTLS(sslSocketFactory.createSocket(s, host, port, autoClose));
+    }
+
+    @Override
+    public Socket createSocket(String host, int port) throws IOException {
+        return enableTLS(sslSocketFactory.createSocket(host, port));
+    }
+
+    @Override
+    public Socket createSocket(String host, int port, InetAddress localHost, int localPort) throws IOException {
+        return enableTLS(sslSocketFactory.createSocket(host, port, localHost, localPort));
+    }
+
+    @Override
+    public Socket createSocket(InetAddress host, int port) throws IOException {
+        return enableTLS(sslSocketFactory.createSocket(host, port));
+    }
+
+    @Override
+    public Socket createSocket(InetAddress address, int port, InetAddress localAddress, int localPort) throws IOException {
+        return enableTLS(sslSocketFactory.createSocket(address, port, localAddress, localPort));
+    }
+
+    private Socket enableTLS(Socket socket) {
+        if ((socket instanceof SSLSocket)) {
+            ((SSLSocket) socket).setEnabledProtocols(new String[]{"TLSv1.2"});
+        }
+        return socket;
+    }
+}