Skip to content

Commit f968db4

Browse files
authored
Merge pull request #1495 from OneSignal/sunset_background_image_layout
Don't set backgroundImageLayout if device is Android 12 or higher
2 parents 54e4b0f + 338da7d commit f968db4

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

Examples/OneSignalDemo/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ apply plugin: 'com.onesignal.androidsdk.onesignal-gradle-plugin'
22
apply plugin: 'com.android.application'
33

44
android {
5-
compileSdkVersion 30
5+
compileSdkVersion 31
66
defaultConfig {
77
minSdkVersion 16
8-
targetSdkVersion 30
8+
targetSdkVersion 31
99
versionCode 1
1010
versionName "1.0"
1111
multiDexEnabled true

OneSignalSDK/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ buildscript {
44

55
ext {
66
buildVersions = [
7-
compileSdkVersion: 30,
8-
targetSdkVersion: 30
7+
compileSdkVersion: 31,
8+
targetSdkVersion: 31
99
]
1010
androidGradlePluginVersion = '3.6.2'
1111
googleServicesGradlePluginVersion = '4.3.2'

OneSignalSDK/onesignal/src/main/java/com/onesignal/GenerateNotification.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -767,9 +767,13 @@ private static void createSummaryIdDatabaseEntry(OneSignalDbHelper dbHelper, Str
767767
// Keep 'throws Throwable' as 'onesignal_bgimage_notif_layout' may not be available
768768
// This maybe the case if a jar is used instead of an aar.
769769
private static void addBackgroundImage(JSONObject fcmJson, NotificationCompat.Builder notifBuilder) throws Throwable {
770-
// Required to right align image
771-
if (android.os.Build.VERSION.SDK_INT < Build.VERSION_CODES.JELLY_BEAN)
770+
// Not adding Background Images to API Versions < 16 or >= 31
771+
if (android.os.Build.VERSION.SDK_INT < Build.VERSION_CODES.JELLY_BEAN ||
772+
android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
773+
OneSignal.Log(OneSignal.LOG_LEVEL.VERBOSE,
774+
"Cannot use background images in notifications for device on version: " + android.os.Build.VERSION.SDK_INT);
772775
return;
776+
}
773777

774778
Bitmap bg_image = null;
775779
JSONObject jsonBgImage = null;

0 commit comments

Comments
 (0)