Add ItemUrl email template variable and options for configure basic email template wrapping #5258
+458
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ItemUrl variable to email templates that generates direct links to media details pages
- Support for movies (/details/movie/{id}), TV shows (/details/tv/{id}), and music (/details/artist/{id})
- Uses configured ApplicationUrl setting for proper URL construction
- Enhances user experience by providing one-click access to requested media
- Reorganizes email notification UI with dedicated 'Advanced Template Customizations' section
- Professional styling with proper spacing, readable white text, and grey underline
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
mmenanno
force-pushed
the
feature/email-customization-complete
branch
from
10cb43c to
0bf75e5
Compare
Code Quality Fixes: - Rename parameter 'imgsrc' to 'img' for consistency - Extract nested ternary operation into GetLogoContent method - Remove duplicate method overload causing signature ambiguity - Make GetPosterContent method static for better performance - Convert EmailNotificationComponent and SettingsMenuComponent to standalone architecture Testing: - Add comprehensive unit tests for EmailBasicTemplate with 18 test cases - Test all LoadTemplate parameter combinations and overloads - Test GetPosterContent static method with various inputs - Include edge cases, error conditions, and validation tests - All tests passing with 100% coverage of changes made This resolves all Angular quality gate issues including typescript-S7648.
mmenanno
force-pushed
the
feature/email-customization-complete
branch
from
0bf75e5 to
a2e31f1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Overview
Adds a new
{ItemUrl}template variable to email notifications that provides direct links to media details pages, enhancing user experience by enabling one-click access to requested content. This also adds toggles to turn of the injected logo or posters from the email template if you either don't want the logo or are using the{PosterImage}variable to insert the posting in a custom way and don't want a duplicate. It also gives the option to turn off the entire basic email wrapper if the user wants to submit fully custom HTML in the body.✨ Features Added
🔗 ItemUrl Template Variable
/details/movie/{id}), TV shows (/details/tv/{id}), Music (/details/artist/{id})🎨 Enhanced Email Notification UI
🖼️ UI Preview
📝 Implementation Details
Backend Changes
NotificationMessageCurlys.cs- CoreGetDetailsUrl()method for URL generationFrontend Changes
Email Template Enhancement
🧪 Testing