-
Notifications
You must be signed in to change notification settings - Fork 1
Version 2 Alpha 1 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
OffsetMonkey538
merged 55 commits into
v2
from
2-allow-more-operations-than-just-adding-pools
Jul 20, 2025
Merged
Version 2 Alpha 1 #3
OffsetMonkey538
merged 55 commits into
v2
from
2-allow-more-operations-than-just-adding-pools
Jul 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inal LootModifier
…ools' (or the very old one with 'loot_pools') next to 'modifies')
Functions (and conditions in the future) only support matching by type, couldn't figure out a good way to match specific ones
zombies and creepers drop two tnt for some reason??
By default, stuff will be turned into literal matchers. Regex can be enabled by setting `regex` to true. This way literal strings won't need any escaping or surrounded with `\Qtext\E`
… and item Turns out 'Item.getRegistryEntry()' is *actually* deprecated so using Registries.ITEM.get... instead
…iple pools tableModified check was inside the LootPool loop poolModified check was inside the LootPoolEntry loop such a dumbass 🤦
…ified loot tables after /reload command too
Pool and entry in context are @nullable again
…matically Initial solution wouldn't work with /reload, would run it multiple times after exiting and reentering a world, had all sorts of other problems with stuff not being a specific way at that poin tand whatever else Now it will (most likely) always run after a reload is fully complete.
Might work? Got too occupied with fixing the exporting stuff and have no idea if I made sure this worked or not 😅
Misode generator omits the 'minecraft' namespace so no types matched just "block"
Simpler logic and a list with one entry doesn't seem like *too much* boilerplate
yeah... don't ask me what that name was.......
Thank you oh so so much to Mr Smart Guy ❤️❤️❤️ Also thanks the other smart guy and *other* other smart guy ❤️❤️❤️ Adds docs page made with starlight. Should be up to date with v2 alpha 1 and hopefully 🤞🤞🤞 nothing is wrong
1.21.1 support will definitely come, 1.20.5 I'm not sure on.
…ormative and aren't just "oo me dumbass and no find pools and modifies ooo thats what you should definitely be using"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2