-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Get blob fulu #15610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Get blob fulu #15610
Changes from 46 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
8585cf0
wip
james-prysm 66e05f3
wip
james-prysm 7c0304b
adding ssz marshalling
james-prysm 5a9fe2e
updating function for readability
james-prysm 42cee09
adding unit tests and fixing ssz
james-prysm 46bab54
gaz
james-prysm 02e30a3
linting
james-prysm a6fb39e
Merge branch 'develop' into get-blob-fulu
james-prysm 24acebd
fixing test
james-prysm 8ee42d9
Merge branch 'develop' into get-blob-fulu
james-prysm e5ccab8
Merge branch 'develop' into get-blob-fulu
james-prysm f413658
wip
james-prysm cafd647
fixing mock blocker
james-prysm e6c24d7
fixing test
james-prysm ea07965
fixing tests and handler
james-prysm 2a276fa
updating unit test for more coverage
james-prysm 1ab2cf4
adding some comments
james-prysm a67009c
Merge branch 'develop' into get-blob-fulu
james-prysm 2f22c36
self review
james-prysm 484ca08
gofmt
james-prysm a032673
Merge branch 'develop' into get-blob-fulu
james-prysm 9babcfd
updating and consolidating tests
james-prysm 0951df7
Merge branch 'develop' into get-blob-fulu
james-prysm ab251ed
moving functional options so it can be used properly
james-prysm 7baaa25
gofmt
james-prysm 6fb4c58
more missed gofmt
james-prysm 4131f07
Update beacon-chain/rpc/endpoints.go
james-prysm 77f5856
Update beacon-chain/rpc/lookup/blocker.go
james-prysm bcf95ad
Update beacon-chain/rpc/eth/beacon/handlers.go
james-prysm d9b51a8
radek feedback
james-prysm e34cb64
Merge branch 'develop' into get-blob-fulu
james-prysm eed1ee4
fixing tests
james-prysm 83d4291
fixing test
james-prysm b793b98
moving endpoint in test
james-prysm b878bce
removed unneeded comment
james-prysm 6c32c0d
Merge branch 'develop' into get-blob-fulu
james-prysm d736c2e
Merge branch 'develop' into get-blob-fulu
james-prysm 77151bc
fixing linting from latest develop merge
james-prysm bafa4c6
fixing linting from latest develop merge
james-prysm cf5d9d9
Merge branch 'develop' into get-blob-fulu
james-prysm 5d67e0c
Update beacon-chain/rpc/eth/blob/handlers.go
james-prysm ce38c57
Update beacon-chain/rpc/eth/blob/handlers.go
james-prysm 7a49d28
reverting change
james-prysm 1acb5f7
reverting change
james-prysm 9c89696
Merge branch 'develop' into get-blob-fulu
james-prysm ddd726a
adding in better error for which hashes are missing
james-prysm f25289c
Update beacon-chain/rpc/lookup/blocker.go
james-prysm ea4f8c4
fixing unit test
james-prysm 23fc075
gofmt
james-prysm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the alias can be removed because it is identical to the package name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops not sure how that happened
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait it's called field_params so i need to leave it or use the old one
i think field_params is not preferred