Spectests: Use a flat structure for faster test ingestion #15313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
force-pushed
the
flat-spectests
branch
from
c6b4cc8 to
8af426a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR is based on #15312. Please review and merge #15312 before reviewing this PR.
This PR will remain a draft until #15312 merges.
Which issues(s) does this PR fix?
Each test target that ingests the spectest data corpus has to build a runfile tree. This is due to the use of
globwith wildcards rather than hardcoding the files in BUILD. The runfile tree building operation is very expensive and continues to get more expensive as more directories and files are added.Other notes for review
WIP -- I want to test some shard_count configurations and add documentation explaining the filename conventions.
Here are the test results...
Before=46 minutes to run spectests from a new machine.
After=9 minutes to run spectests from a new machine.
Acknowledgements