move account changed channel into validator for code cleanup #15298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
May 16, 2025
| log.WithError(err).Fatal("Failed to update proposer settings") | ||
| } | ||
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| log.Info("Context canceled, stopping validator") | ||
| sub.Unsubscribe() | ||
| close(accountsChangedChan) |
There was a problem hiding this comment.
I removed this line, I think it should be ok
james-prysm
commented
May 16, 2025
| log.WithError(err).Fatal("Failed to update proposer settings") | ||
| } | ||
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| log.Info("Context canceled, stopping validator") | ||
| sub.Unsubscribe() |
There was a problem hiding this comment.
unsubscribe is moved as well to when the the done function
rkapka
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
By moving the accounts changed channel into the validator struct we can cleanup a lot of code around wait for activation and runner initialization. we also avoid passing the channel around which is a plus
part of #14779
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements