merge builder and structs payload types #15283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
Cleanup
Comment on lines
-1997
to
-2001
| require.NoError(t, err) | ||
| pb, err := pp.PayloadProto() | ||
| if err == nil { | ||
| require.NoError(t, err) | ||
| require.Equal(t, false, pb == nil) |
There was a problem hiding this comment.
Can you explain these changes?
There was a problem hiding this comment.
because payloadProto can't get called anymore if it's already nil in parsepayload, it just errors earlier now because of how it works
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
we have the execution payload types defined several times in our code base, and although maybe we aren't able to merge them all, there is a case to be said for merging the HTTP REST and builder API definitions as they are essentially the same. This PR merges the use case of these types with a preference for the types defined for the rest APIs.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements