chore: Address TODO to use ROBlock #15193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR refactors the
backfill.verifier.verifyfunction to accept[]blocks.ROBlockdirectly, addressing an existingTODOcomment. This simplifies the verification logic by removing the internal conversion frominterfaces.ReadOnlySignedBeaconBlocktoblocks.ROBlockand leverages the cached root withinROBlock.Which issues(s) does this PR fix?
Fixes # (Addresses inline
TODOinbeacon-chain/sync/backfill/verify.go)Other notes for review
This change primarily involves updating the function signature and adjusting the call sites in
worker.goandverify_test.go. No functional changes are intended. A user-facing changelog entry is likely not required as this is internal refactoring.Acknowledgements