chore: remove app.kubernetes.io/version label from all charts #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the app.kubernetes.io/version label from the common labels in all charts (nitro, relay, das). This label is not needed and creates unnecessary diff when the appVersion changes frequently.
- nitro: 0.7.9 -> 0.7.10 - relay: 0.6.4 -> 0.6.5 - das: 0.6.4 -> 0.6.5
Chart Installation Test succeeded ✅The chart installation test for commit Changed charts: |
ckarabats
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
app.kubernetes.io/versionlabel from all charts to avoid unnecessary diffs when appVersion changes.Changes
app.kubernetes.io/versionlabel from common labels in:Why?
The
app.kubernetes.io/versionlabel creates unnecessary diffs in deployed resources whenever the appVersion changes, even if there are no other changes to the deployment. This label is not required and removing it simplifies upgrades.Test plan