feat(nitro): add configmap.removeKeys to remove config entries #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new feature to the nitro helm chart that allows removing configuration
entries entirely by specifying keys in configmap.removeKeys. This helps with
backwards compatibility when nitro releases have different CLI arguments.
Features:
- Support removing entire config sections (e.g., "ws", "pprof")
- Support removing nested fields using dot notation (e.g., "metrics-server.port")
- Add CI testing with bogus fields to verify functionality
Example usage:
```yaml
configmap:
removeKeys:
- "deprecated-section"
- "node.old-field"
```
Chart Installation Test succeeded ✅The chart installation test for commit Changed charts: |
ckarabats
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
configmap.removeKeysfeature to allow removing configuration entries entirelyFeatures
"ws","pprof")"metrics-server.port")Example usage
Test plan
charts/nitro/ci/sepolia-values.yaml