feat(nitro): add env-prefix validation to prevent configuration conflicts #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icts Add validation to detect when env-prefix conflicts with service names, preventing Kubernetes service environment variables from being interpreted as configuration keys. This resolves issues where release names starting with the env-prefix cause cryptic configuration errors.
Chart Installation Test succeeded ✅The chart installation test for commit Changed charts: |
ckarabats
approved these changes
Jul 16, 2025
AClarkie
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds validation to detect when
env-prefixconflicts with service names, preventing Kubernetes service environment variables from being interpreted as configuration keys. This resolves cryptic configuration errors when release names start with the env-prefix (e.g., usingenv-prefix: "NITRO"with release namenitro-sepoliacausesNITRO_SEPOLIA_SERVICE_HOSTto be parsed as config keysepolia).Which issue this PR fixes
Fixes configuration conflicts that cause nitro nodes to crash with "invalid keys" errors when service names conflict with env-prefix.
Special notes for your reviewer:
env-prefixis set, allowing flexibility for deployments that don't use environment variable configurationChecklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]