Wrapper super ivim #107
Wrapper super ivim #107
Conversation
added to wrapper. Needed to adapt some testing. BOBYQA does not work (an import is skipped in the package) - added a function to switch D and D* when D>D* in OSIPI base - added exception in testing for when f=1 or 0 and there are no fit bounds
removed SLS from testing, as not properly implemetned on package.
| @@ -1,5 +1,7 @@ | |||
| { | |||
| "algorithms": [ | |||
| "TCML_TechnionIIT_lsqlm", | |||
There was a problem hiding this comment.
Is there a reason to omit the other 2?
There was a problem hiding this comment.
Yes, the other two algorithms fail within the package itself. One refers to a variable that is not initiated. The other has the bounds not properly implemented. As the code is in a package, we cannot modify it. I've asked the authors to take a look.
| results["f"] = fit_results[2] | ||
| results["Dp"] = fit_results[1] | ||
|
|
||
| return self.D_and_Ds_swap(results) |
There was a problem hiding this comment.
Is there a reason to just do it here and not generally in the wrapper?
There was a problem hiding this comment.
Good question. I think for bounded fits it is less of an issue. But it will not do any harm. But I will move it to the general wrapper indeed.
yes, the package from super-ivim-dc is not working for pyhton 11 and 12, presumably as they have hardcoded an import of older packages in there. Potentially if they remove the ==1.2.3. from their package==1.2.3 import, it will use the latest versions of the packages and build properly for python 11 and 12. For other python releases all tests succeed. Let's leave this PR here until these things are fixed by the authors :) |
move swapping of D and D* to general wrapper stretch exclusion criteria
Describe the changes you have made in this PR
Added four of the SuperIVIM algorithms to wrapper. Only 2 are being tested as the other two show errors at the package side (SLS skips bounds and BOBYQA does misses an import statement).
Link this PR to an issue [optional]
Fixes #ISSUE-NUMBER
Checklist