Prepare for 1.6.1 release #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbeu
suggested changes
Aug 10, 2024
| <li>Only test for _WIN32 for Windows detection</li> | ||
| <li>Windows: Fix UTF8 hook functions</li> | ||
| <li>Various compiler warning fixes</li> | ||
| <li>contrib/csv2shp.c: fix resource leaks (#86)</li> |
There was a problem hiding this comment.
Why is there a reference to the GitHub issue here, but not on the previous lines or rather at all lines?
There was a problem hiding this comment.
I use what is available in commit messages.
There was a problem hiding this comment.
Do you know the auto-release notes generation feature of GitHub? It helps to keep track of the PR based changes.
thanks, added (the messages you propose here make much more sense to me than the raw commit messages I use to build the change log, and I tend to skip the ones I can't immediately make sense of, so this is an encouragement in providing more descriptive commit messages :-)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thbeu If you want to have a look at the changelog to check it reflects correctly the changes