Fix warnings in callback examples #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

alexander-novo merged 1 commit into add-ida-callbacks from slaven/add-ida-callbacks

May 6, 2025

Collaborator

pelesh commented May 6, 2025 •

edited

Loading

Description

Fixes warnings in #91 related to

conversion double to int
using C++20 extensions

Proposed changes

Use static cast to compute number of time steps as an integer.
Replace C++20 syntax with C++11 compatible

Checklist

All tests pass.
Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
The new code follows GridKit™ style guidelines.
There are unit tests for the new code.
The new code is documented.
The feature branch is rebased with respect to the target branch.

Further comments

None


          Fix warnings in callback examples

bd14df1

pelesh requested a review from alexander-novo

May 6, 2025 21:32

pelesh self-assigned this

pelesh marked this pull request as ready for review

May 6, 2025 21:33

alexander-novo merged commit fa4fe6b into add-ida-callbacks

2 of 3 checks passed

pelesh deleted the slaven/add-ida-callbacks branch

June 10, 2025 18:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet