Reorganize model evaluator implementations #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelesh
changed the title
pelesh
added a commit
that referenced
this pull request
Apr 14, 2025
* Replace ModelEvaluator class. * Remove ModelEvaluatorImpl dependence for power electronics models. * Move power flow specific files to Model/PowerFlow dir. * Add phasor dynamics system composer. * Add test for system composer. * Add template for implementing synchronous machine model. * Add testing framework for the synchronous machine model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize model evaluator interface implementations for different families of models in a following way:
Model::Evaluator, which defines interfaces to simulation models is in the filesrc/Model/Evaluator.hpp.Model::Evaluatorclass are separate for each model family:PhasorDynamics::BusBaseandPhasorDynamics::Componentfor phasor dynamics components,CircuitComponentfor power electronics components, andModelEvaluatorImplfor power flow components.