Additional Enzyme examples and use cases (e.g DistributedGenerator) #54

nkoukpaizan · 2025-02-11T21:14:30Z

This is work in progress to use Enzyme to compute Jacobians
Status:

Working example testing the basic functionality for vector-valued function Jacobians
Working examples testing the basic functionality of differentiating a complex object with respect to its member variables
Working example verifying the correctness of the Jacobian for the DistributedGenerator residual using a local copy of the method.

Co-authored-by: pelesh <peles2@llnl.gov>

…d mode.

…ed to find a better way.

pelesh · 2025-02-19T19:29:03Z

If you have time, feel free to start adding some suggestions. This is going to be a long PR.

Perhaps we should consider breaking this into a series of PRs, each with very specific focus?

nkoukpaizan · 2025-02-20T14:49:33Z

Perhaps we should consider breaking this into a series of PRs, each with very specific focus?

I agree. It's getting harder to keep this branch up to date with develop as well.

nkoukpaizan · 2025-02-20T14:53:04Z

I marked the PR as ready for review. I will create other PRs for the next features.

shakedregev

Left mentions on some variable names that should be changed throughout.
There are no comments on any of the test functions.
Code passes all tests, so I approved it.

examples/DistributedGeneratorTest/CMakeLists.txt

examples/Enzyme/Library/Scalar/EnzymeWrapper.hpp

examples/Enzyme/Library/Scalar/ScalarModel.hpp

examples/Enzyme/Library/Vector/VectorModel.cpp

examples/Enzyme/PowerElectronics/main.cpp

examples/Enzyme/Standalone/EnzymeScalar.cpp

examples/Enzyme/PowerElectronics/main.cpp

reid-g

Overall looks good to me.

…for a follow-up PR.

examples/Enzyme/Library/Scalar/EnzymeScalar.cpp

pelesh

Looks good. Some code style issues still need to be addressed.

) * Add preliminary Enzyme support * Use better naming conventions * More verbose tests for enzyme support. * int --> double in Enzyme examples. * Separate scalar and vector examples using Enzyme. * Use classes in EnzymeLibCheck. * Basic usage of DenseMatrix in EnzymeVector example. * Method to convert Dense matriz to COO. * Use DenseMatrix to store the Jacobians in Enzyme vector example. * Working Enzyme derivative of DistributedGenerator * EnzymeLibVectorCheck. * Better documentation of the DenseMatrix class. --------- Co-authored-by: Asher Mancinelli <ashermancinelli@gmail.com> Co-authored-by: pelesh <peles2@llnl.gov> Co-authored-by: Slaven Peles <peless@ornl.gov>

nkoukpaizan and others added 30 commits February 3, 2025 13:02

Fix spacing in Enzyme basic examples.

ba3ea2a

SparseMatrix directory.

2904eff

Add preliminary Enzyme support

8254ce2

Use better naming conventions

8b50a7e

Apply suggestions from code review

be8f2e8

Co-authored-by: pelesh <peles2@llnl.gov>

More verbose tests for enzyme support.

3d608a3

int --> double in Enzyme examples.

536865e

Minor name changes for Enzyme tests.

aa7b2c8

Separate scalar and vector examples using Enzyme.

b508275

Jacobian of vector input function is diagonal. Using Enzyme in forwar…

119b572

…d mode.

Attempt to use classes in EnzymeLibCheck.

23dc868

Minor improvements in scalar and vector Enzyme standalone tests.

0d08de1

Minor name change for Enzyme test files.

cc83e0f

Move Enzyme examples.

fa3c09a

Minor edits to match develop

caeef0c

LinearAlgebra directory in examples and DenseTest.

e999877

Fix path of example using Enzyme for vectors and Jacobians.

c0694dd

Enzyme vector/Jacobian example.

ee0c9a9

Cleanup Enzyme CMakeList.

1a6260d

Bug fix (type): columns in DenseMatrix.

e84ad62

A very manual way to link GridKit targets with Enzyme executables. Ne…

9294ed3

…ed to find a better way.

Fixed spacing in Enzyme examples

2d9200b

Basic usage of DenseMatrix in EnzymeVector example.

88845a6

Intdx-->IdxT

2ff261e

Method to convert Dense matriz to COO.

991dca1

Use DenseMatrix to store the Jacobians in Enzyme vector example.

7f5d49f

Typo fix in CMakeLists: mirco-->micro.

c918663

Minor formatting.

f11e460

pragma once for COO_Matrix.

4b39fe8

Better way to ensure paths exist for INCLUDES in enzyme_add_executable.

91e291c

nkoukpaizan requested review from alexander-novo, pelesh, shakedregev and reid-g February 11, 2025 21:14

nkoukpaizan self-assigned this Feb 11, 2025

nkoukpaizan added automatic differentiation enhancement New feature or request labels Feb 11, 2025

nkoukpaizan changed the title ~~Additional Enzyme example and use case for DistributedGenerator~~ Additional Enzyme examples and use cases (e.g DistributedGenerator) Feb 11, 2025

nkoukpaizan added 2 commits February 13, 2025 10:28

Merge branch 'develop' into nicholson/enzyme-usecase

4ac1e49

ModelLib -> GridKit on this branch.

be03069

nkoukpaizan added 2 commits February 20, 2025 09:28

Merge 'develop' into 'nicholson/enzyme-usecase'.

a385880

Better documentation of the DenseMatrix class.

8329bf9

nkoukpaizan marked this pull request as ready for review February 20, 2025 14:49

shakedregev approved these changes Feb 20, 2025

View reviewed changes

Rename a few variables in Enzyme examples.

140c2b7

nkoukpaizan mentioned this pull request Feb 24, 2025

Automatic differentiation with Enzyme #62

Open

4 tasks

nkoukpaizan added 2 commits February 24, 2025 14:54

Merge 'develop' into 'nicholson/enzyme-usecase'.

fc974dc

powerelec --> power_elec in GRIDKIT::targets.

356d8a5

reid-g reviewed Feb 25, 2025

View reviewed changes

examples/Enzyme/PowerElectronics/main.cpp Show resolved Hide resolved

reid-g approved these changes Feb 25, 2025

View reviewed changes

Added comments to describe the Enzyme examples along with TODO items …

495ab8c

…for a follow-up PR.

pelesh reviewed Feb 27, 2025

View reviewed changes

examples/Enzyme/Library/Scalar/EnzymeScalar.cpp Outdated Show resolved Hide resolved

pelesh approved these changes Feb 27, 2025

View reviewed changes

Fix braces in Enzyme examples.

4fc7f46

pelesh merged commit c3d86e6 into develop Feb 27, 2025
2 checks passed

nkoukpaizan deleted the nicholson/enzyme-usecase branch May 13, 2025 13:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Additional Enzyme examples and use cases (e.g DistributedGenerator) #54

Additional Enzyme examples and use cases (e.g DistributedGenerator) #54

Uh oh!

nkoukpaizan commented Feb 11, 2025 •

edited

Loading

Uh oh!

pelesh commented Feb 19, 2025

Uh oh!

nkoukpaizan commented Feb 20, 2025

Uh oh!

nkoukpaizan commented Feb 20, 2025

Uh oh!

shakedregev left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reid-g left a comment

Uh oh!

Uh oh!

pelesh left a comment

Uh oh!

Uh oh!

Uh oh!

Additional Enzyme examples and use cases (e.g DistributedGenerator) #54

Additional Enzyme examples and use cases (e.g DistributedGenerator) #54

Uh oh!

Conversation

nkoukpaizan commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelesh commented Feb 19, 2025

Uh oh!

nkoukpaizan commented Feb 20, 2025

Uh oh!

nkoukpaizan commented Feb 20, 2025

Uh oh!

shakedregev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reid-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pelesh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nkoukpaizan commented Feb 11, 2025 •

edited

Loading

shakedregev left a comment •

edited

Loading