Skip to content

Adding new version of example3 with GenClassical #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2025
Merged

Adding new version of example3 with GenClassical #148

merged 3 commits into from
Jun 20, 2025
+259 −58

Conversation

abirchfield
Copy link
Collaborator

@abirchfield abirchfield commented Jun 19, 2025 •
edited
Loading

Description

Adding new version of example3 with GenClassical, plus necessary bug fixes.

Proposed changes

  • New Example3_GenClassical example
  • Bug fixes on GenClassical model itself
  • Correction to GenClassical documentation
  • Correction to GenClassical tests

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

@abirchfield abirchfield self-assigned this Jun 19, 2025
@abirchfield abirchfield added bug Something isn't working examples labels Jun 19, 2025
@abirchfield abirchfield marked this pull request as ready for review June 19, 2025 19:28
@abirchfield abirchfield requested a review from pelesh June 19, 2025 19:28
pelesh
pelesh approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@pelesh pelesh merged commit 721ed57 into develop Jun 20, 2025
@abirchfield abirchfield deleted the create-example3classical branch June 20, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelesh pelesh pelesh approved these changes

Assignees

@abirchfield abirchfield

Labels
bug Something isn't working examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abirchfield @pelesh