-
Notifications
You must be signed in to change notification settings - Fork 5
Add component data structures #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending me figuring out how to build.
The following tests FAILED: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix test 13
13 - AdjointSens (SEGFAULT)
@shakedregev is your sundials version from the develop branch? this is probably the reason for the segfault. see this comment |
Can I get some more details on how to fix this? I tried both locally and on Frontier to install sundials on develop and failed. Pretend I am a bot that only knows how to run commands in the terminal and tell me the steps to get this to work. Assume I have cloned GridKit and spack. Alternatively, if I installed sundials@develop with spack, tell me what I should set my directories to in ccmake, because it didn't find it when I put where I think it installed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass. The functionality of the code is good. Hopefully the guideline fixes are not too difficult.
Description
Create data structures for each component model type that stores all modeling data.
@alexander-novo @reid-g @nkoukpaizan @shakedregev
Proposed changes
The data structures contain connectivity information and model parameters for each component model type and as such can be understood as meta models. For example, system matrix sparsity pattern and allocations can be done with information stored in these data structures without instantiating component or system models.
The idea is that these data structures are populated by the GridKit input. GridKit then operates on that data to allocate workspaces and instantiate and parametrize component models.
In this PR:
Checklist
-Wall -Wpedantic -Wconversion -Wextra
.Further comments
This is first stage in implementing meta models in GridKit. The objective of this PR is to have a matching data structure for each component model type.