Skip to content

Update required sundials version in README #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Conversation

alexander-novo
Copy link
Collaborator

Description

Update the required version of SUNDIALS to include specific fixes we need. See this comment by @pelesh.

Proposed changes

List the specific commit needed until a release is made with the fix.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

@alexander-novo alexander-novo added the documentation Improvements or additions to documentation label May 28, 2025
Copy link
Collaborator

@superwhiskers superwhiskers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see anything wrong with this.

Co-authored-by: pelesh <peless@ornl.gov>
@pelesh pelesh merged commit 6b4f378 into develop May 30, 2025
3 checks passed
@nkoukpaizan nkoukpaizan mentioned this pull request Jun 2, 2025
10 tasks
@pelesh pelesh deleted the update-sundials-version branch June 10, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants