Skip to content

Move PowerSystemsData.hpp and CircuitGraph.hpp to correct subdirectories #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2025

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented May 26, 2025

Description

  • Move PowerSystemsData.hpp -> src/Model/PowerFlow.
  • Move CircuitGraph.hpp -> src/Model/PowerElectronics.
  • Separated Matpower parser from FileIO.hpp as it is needed only for power flow models.
  • Remove unnecessary include directives

@alexander-novo @abdourahmanbarry @reid-g @abirchfield @lukelowry

Proposed changes

PowerSystemsData.hpp is used only by power flow and experimental models. It is specific to Matpower input data and will not be used for phasor domain dynamics models.

CircuitGraph.hpp is used only for power electronics models.

Most of the models do not need to include either of the two header files.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

@pelesh pelesh requested a review from nkoukpaizan May 26, 2025 22:41
@pelesh pelesh self-assigned this May 26, 2025
@pelesh pelesh added enhancement New feature or request good first issue Good for newcomers labels May 26, 2025
@pelesh
Copy link
Collaborator Author

pelesh commented May 27, 2025

CC @superwhiskers

Copy link
Collaborator

@nkoukpaizan nkoukpaizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Tests pass in CI and on Frontier.

@pelesh pelesh merged commit 15602b7 into develop May 27, 2025
@pelesh pelesh deleted the slaven/refactor_powerflow_dev branch June 10, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants