Minor suggestions to SUNDIALS interface #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create "symmetric" functions for creating and deleting SUNDIALS objects. - Modify RL example to test Ida destructor.
Steven-Roberts
approved these changes
May 22, 2025
pelesh
added a commit
that referenced
this pull request
May 22, 2025
* Improvements for IDA and KINSOL * Remove N_VGetArrayPointer_Serial calls * Resolve t_init_ issue * Add missing N_VDestroy * Apply pre-commmit fixes * Fix some adjoint memory leaks * Remove unused function * Minor suggestions to SUNDIALS interface (#111) - Create "symmetric" functions for creating and deleting SUNDIALS objects. - Modify RL example to test Ida destructor. --------- Co-authored-by: pelesh <pelesh@users.noreply.github.com> --------- Co-authored-by: Steven-Roberts <Steven-Roberts@users.noreply.github.com> Co-authored-by: pelesh <peless@ornl.gov> Co-authored-by: Nicholson Koukpaizan <koukpaizannk@ornl.gov> Co-authored-by: pelesh <pelesh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposed changes
Minor suggestion to include in #105 to give user more flexibility for creating and deleting IDA components.
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments