-
Notifications
You must be signed in to change notification settings - Fork 5
Refactor examples #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor examples #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests currently pass. I left a few suggestions and would like to test again after they are addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, as we've discussed that command line arguments for verbosity (#112) and the isEqual
template design are out of scope for this PR.
Description
Several minor issues related to examples are addressed here:
@alexander-novo @abdourahmanbarry
Proposed changes
Comment out redundant output, add accuracy checks where missing and fix compiler warnings for all examples.
Move helper functions for Matpower parser tests to
examples/PowerFlow/MatPowerTesting/MatPowerTesting.hpp
.Checklist
-Wall -Wpedantic -Wconversion -Wextra
.Further comments
None.