[18.0][IMP] spreadsheet*_oca: Remove unnecessary options on spreadsheet insertions #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ertions 1- Removed the option to add in a new sheet; this will now be the default behavior of the option to add to an existing spreadsheet. Due to the nature of tables, they are always dynamic and structured in such a way that cells don’t contain static content, making it impossible to determine where previously inserted tables end within the spreadsheet. Therefore, we’ve chosen to follow Odoo’s approach, which always inserts data into new sheets. 2- Removed the use of dynamic column fields, as they are no longer used. Only dynamic rows are used now, for cases when a tree view is inserted.
pedrobaeza
approved these changes
Oct 13, 2025
carlos-lopez-tecnativa
approved these changes
Oct 13, 2025
|
@etobella do you agree? |
|
This PR has the |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 17fef71. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- Removed the option to add in a new sheet; this will now be the default behavior of the option to add to an existing spreadsheet. Due to the nature of tables, they are always dynamic and structured in such a way that cells don’t contain static content, making it impossible to determine where previously inserted tables end within the spreadsheet. Therefore, we’ve chosen to follow Odoo’s approach, which always inserts data into new sheets.
2- Removed the use of dynamic column fields, as they are no longer used. Only dynamic rows are used now, for cases when a tree view is inserted.
cc @Tecnativa TT58043
ping @pedrobaeza @etobella @carlos-lopez-tecnativa