[18.0][FIX] spreadsheet_oca: Crash editing and leaving spreadsheet quickly #77
Conversation
|
@etobella @pedrobaeza Could you please test when you have chance? |
|
@chrisandrewmann please follow commit message guidelines (https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message):
I think it's not the first time I have commented to you this. |
chrisandrewmann
changed the title
…ckly When editing a spreadsheet, inserting a pivot or list or making signficant changes, exiting quickly could intermittently cause a race condition where saving does not have enough time to complete. After reloading the record, it crashes with an OWL error "Component Destroyed". This fixes the issue by awaiting the save methods before exiting.
All done, I don't remember you mentioning it before but i'll try to remember next time. |
There was a problem hiding this comment.
Sorry, I wasn't mean to be rude with my comment. It was just that I have seen several times this among contributors, and don't know the reasons for not putting the module name. Maybe it's stated in any place that should be corrected?
And thanks of course for the patch. We all contribute for the shared benefit.
/ocabot merge patch
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at f31daf7. Thanks a lot for contributing to OCA. ❤️ |
4 participants
Fix for issue #76