[DRAFT] Revert "[FIX] base_tier_validation: Proper notifications on reviews" #1178
+9
−201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 19e0337.
Contributor
|
Hi @LoisRForgeFlow, |
Member
|
Why? |
Author
|
Hello @pedrobaeza Whe you have more than one definition created with the same responsable, it doesn´t send email in the last definition approve, we re testing it so far, but we think it's related to this change |
Member
|
But the solution is not to revert something, but fix it. Please expose the complete steps to reproduce the problem, and we can help hunting the bug, or better, add a regression test with such steps that fail right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 19e0337.