v3.2: Allow allowReserved in the Header Object (left out of PR #4593 by mistake)
#4680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added it in the Parameter and Encoding Objects but forgot the Header Object (again).
handrews
added
param serialization
miqui
approved these changes
Jun 12, 2025
This was referenced Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added it in the Parameter and Encoding Objects in PR #4593 but forgot the Header Object (again). Appendix D, which deals with header and cookie serialization, was already updated in the earlier PR. We just forgot the Header Object.
See PR #4673 for an example where this is used, which is what made me realize we forgot it!