Skip to content

Fix clippy error in async-compression #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jun 9, 2025
Merged

Fix clippy error in async-compression #347

merged 29 commits into from
Jun 9, 2025

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented Jun 9, 2025

No description provided.

NobodyXu added 29 commits June 10, 2025 00:13
@NobodyXu
Fix clippy error in brotli decoder.rs
5ab7ecd 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in brotli encoder.rs
b8f73f6 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix encoder.rs
5c6b3c0 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in bzip2 decoder.rs
7e6da26 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in flate decoder.rs
abdacc9 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in flate encoder.rs
f4769ff 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in gzip header.rs
b8b89bc 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in gzip encoder.rs
88c171b 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in gzip decoder.rs
3410595 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in gzip encoder.rs
12059f9 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in tokio generic decoder.rs
dc239cb 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in tokio generic encoder.rs
4882199 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in future write generic decoder.rs
c175b91 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in futures write generic encoder.rs
e4d68ef 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix doc link in lib.rs
9f16070 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in bzip2 decoder.rs
381bf51 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in bzip2 encoder.rs
c20c334 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in bzip2 encoder.rs
5da6467 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in xz2 decoder.rs
6149d57 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error in tokio/write/generic/decoder.rs
9c3b915 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix fmt in brotli decoder.rs
2834e8c 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix fmt in xz2 decoder.rs
cd0c04f 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix clippy error and fmt in xz2 encoder.rs
b0517cc 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix fmt in decoder.rs
5ea5bdf 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix fmt in future write generics encoder.rs
6eeed32 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix fmt in tokio write generics decoder.rs
a5059d7 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix fmt in tokio generics write encoder.rs
71ead80 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix tokio write generics decoder.rs
6569497 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix fmt in decoder.rs
52d7d4c 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu NobodyXu enabled auto-merge June 9, 2025 15:15
@NobodyXu NobodyXu added this pull request to the merge queue Jun 9, 2025
Merged via the queue into main with commit 9b938da Jun 9, 2025
17 checks passed
@NobodyXu NobodyXu deleted the fix/clippt branch June 9, 2025 15:19
@codecov Codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (aa03267) to head (52d7d4c).
Report is 30 commits behind head on main.

Additional details and impacted files 
@@     Coverage Diff     @@
##   main   #347   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Jun 9, 2025

Damn I thought we are using squash merge...

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Jun 9, 2025

Turns out that the branch protection isn't updated and still used the banned merge commit.

Updated and should have fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NobodyXu