-
Notifications
You must be signed in to change notification settings - Fork 496
Improve pruning documentation #3444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+110
−9
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1852c32
Improve the pruning documentation
nkolev92 8dbbe05
Improve the pruning documentation
nkolev92 080bf37
Update docs/consume-packages/Package-References-in-Project-Files.md
nkolev92 d9353cf
Update docs/consume-packages/Package-References-in-Project-Files.md
nkolev92 c89c504
improve docs
nkolev92 f1f3133
Apply suggestions from code review
nkolev92 aca1826
Update docs/reference/errors-and-warnings/NU1510.md
nkolev92 789af58
clarify frameworks
nkolev92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for preview 7+? I don't see this with preview 6. (And I need to set -tl:off to see anything interesting with
dotnet build
otherwise I just see the really compact build output)Interestingly if I target .NET 8 I see
But when I target .NET 10 I see
I don't see System.Memory.dll in either bin folder (when System.Memory is transitively referenced via Azure.Identity@1.14.2) (not when targeting .NET 7 either) maybe that's expected?
And direct deps if I add just System.Memory directly isn't "fully" pruned as we discussed below and doesn't show up either. And NU1510 is triggered which says it will not be pruned. So line 497 isn't really what I see either?