Skip to content

Fix NuGet->SDK Codeflow #6554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 16, 2025
Merged

Conversation

baronfel
Copy link
Contributor

@baronfel baronfel commented Jul 14, 2025

Fixes: NuGet/Home#14431

The VMR updated S.CL across the whole codebase, but that hasn't flowed back here yet (see #6482 for discussion), but now this is blocking SDK codeflow. So this is the S.CL changes only to unblock the rest of the product.

@baronfel baronfel requested a review from a team as a code owner July 14, 2025 15:51
@baronfel baronfel requested review from nkolev92 and donnie-msft July 14, 2025 15:51
@dotnet-policy-service dotnet-policy-service bot added the Community PRs created by someone not in the NuGet team label Jul 14, 2025
aortiz-msft
aortiz-msft previously approved these changes Jul 14, 2025
nkolev92
nkolev92 previously approved these changes Jul 14, 2025
@nkolev92
Copy link
Member

nkolev92 commented Jul 14, 2025

@baronfel I think you probably need to unpin https://github.com/NuGet/NuGet.Client/blob/dev/build/DotNetSdkTestVersions.txt#L2 to get the tests to work (assuming the problem Andy talked about is addressed)

@baronfel baronfel dismissed stale reviews from nkolev92 and aortiz-msft via 059b123 July 14, 2025 17:22
@baronfel
Copy link
Contributor Author

I need a bit of expertise here - the tests that are failing are failing because the NuGetSdkResolver (which is shipped in the SDK but possibly copied over for testing) can't load NuGet.Common 7.0.0.0, but I don't know if that dll is also being copied over, or if there's a real binary build break, or some other explanation.

@nkolev92
Copy link
Member

This is where the copying is happening: https://github.com/NuGet/NuGet.Client/blob/c08c2c29435d9ae4a8b738096033cae175485c03/test/TestUtilities/Test.Utility/TestDotnetCLiUtility.cs

Not super clear to me without debugging whether the sdk resolver assembly is getting copied.
I'd expect it to be a patching problem to be honest.

@baronfel
Copy link
Contributor Author

I'll come back to this tomorrow. I was able to run the tests locally and they seem to work for me, so I'm down to trying to diff my environment from the CI environment.

@zivkan zivkan enabled auto-merge (squash) July 15, 2025 23:54
@zivkan zivkan merged commit 01c5622 into NuGet:dev Jul 16, 2025
17 checks passed
@baronfel baronfel deleted the bump-scl-to-prevent-load-errors branch July 16, 2025 01:42
@baronfel
Copy link
Contributor Author

Thanks for the merge! Do you know if this should trigger flow from NuGet.Client => VMR? I am expecting to see that, and then for flow from VMR=>SDK to happen to unblock dotnet/sdk#49740.

@jjonescz
Copy link

NuGet.Client flows directly to SDK as well - and it's already in a flow PR there: dotnet/sdk#49743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can clear nuget cache after update to sdk 10.0.100-preview.7.25368.105
5 participants