Chore: Update All Dependencies and Resolve TypeScript & ESLint Issues #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of an assignment expression, as it is simpler to read @typescript-eslint/prefer-nullish-coalescing
… value of the string @typescript-eslint/no-unnecessary-type-conversion
…t from "react"'; @eslint-react/prefer-namespace-import & Prefer importing React DOM via a namespace import @eslint-react/dom/prefer-namespace-import
│ React refs are values that are not needed for rendering. Refs should only be accessed outside of render, such as in event handlers or effects.
… from Uint8Array to ArrayBuffer
… 'initSegment'. In the code we use instance of class MediaSegment which extends Fragment and overrides sn type to number
…gmentReference[]'.
Type 'SegmentReference | null' is not assignable to type 'SegmentReference'.
Type 'null' is not assignable to type 'SegmentReference'
…rayBuffer'.
The types of 'slice(...)[Symbol.toStringTag]' are incompatible between these types.
Type '"Uint8Array"' is not assignable to type '"ArrayBuffer"'.
DimaDemchenko
commented
Oct 21, 2025
| start: startTime, | ||
| end: endTime, | ||
| } = fragment; | ||
| if (sn === "initSegment") return; |
There was a problem hiding this comment.
fragment here is an instance of class MediaFragment.
It overrides type of class Fragment in which sn could be number | "initSegment"
|
|
||
| get data(): ArrayBuffer { | ||
| if (!this.finalData) this.finalData = Utils.joinChunks(this.bytes); | ||
| this.finalData ??= Utils.joinChunks(this.bytes).buffer as ArrayBuffer; |
There was a problem hiding this comment.
Uint8Array.buffer is typed as ArrayBufferLike, which means it could be either an ArrayBuffer or a SharedArrayBuffer.
However, in this case, it will always be a regular ArrayBuffer based on how joinChunks is implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background Information
This pull request includes dependency updates, ESLint configuration improvements, ESLint warning fixes, and type error fixes.