Handle CLUSTER error from GCP Memorystore Redis standalone gracefully #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjosv
reviewed
Mar 13, 2025
There was a problem hiding this comment.
Good finding. When looking into this I notice that the old check only seems to have worked with Redis from the Jurassic era.
I think we should replace current match with your change.
Not sure if its easily tested with current setup, but we can add that separately.
When Redis is running in standalone (un-clustered) mode, it will return error messages in one of two formats: - ERR This instance has cluster support disabled - ERR unknown command `CLUSTER`, with args beginning with: It appears the current error handler is for very old versions of Redis and is safe to remove/replace.
|
Excellent, good thinking @bjosv ! Just updated the commit to only handle the current error message Lmk if you need anything else |
|
Looks great. I (re-)added the handling of the single quote variant and parts of your comment. |
|
Thanks @bjosv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCP Memorystore Redis returns a slightly different error message for the CLUSTER command when running in standalone mode:
ERR unknown command
CLUSTER, with args beginning with:SLOTS,The code currently only supports servers that return
'CLUSTER'wrapped in single quotes and with no additional mention of args.