fix: update isbinaryfile to fix an issue with protobuf parsing causing hanging #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using this package to analyze repositories in order to determine the languages used. Some repositories will hang while processing. This is caused by a bug in the isbinaryfile package in the way it processes files to determine if the file is a protobuf. This package also had a bug in how it handled errors in a callback when promises were used. Both of these bugs were fixed and published in
5.0.5
and5.0.6
.NPM versions: https://www.npmjs.com/package/isbinaryfile?activeTab=versions
This PR updates
isbinaryfile
to5.0.6
.