Skip to content

Conversation

dclayton-godaddy
Copy link

@dclayton-godaddy dclayton-godaddy commented Sep 3, 2025

We are using this package to analyze repositories in order to determine the languages used. Some repositories will hang while processing. This is caused by a bug in the isbinaryfile package in the way it processes files to determine if the file is a protobuf. This package also had a bug in how it handled errors in a callback when promises were used. Both of these bugs were fixed and published in 5.0.5 and 5.0.6.

NPM versions: https://www.npmjs.com/package/isbinaryfile?activeTab=versions

This PR updates isbinaryfile to 5.0.6.

@dclayton-godaddy dclayton-godaddy marked this pull request as ready for review September 3, 2025 20:24
@Nixinova
Copy link
Owner

Nixinova commented Sep 4, 2025

Thanks for the contribution!

I have isbinaryfile pinned to v4 because v5 contains a breaking change to the minimum supported node version. So you know if this fix is going to be back ported to v4 at all?

@dclayton-godaddy
Copy link
Author

Good catch. Asking... gjtorikian/isBinaryFile#87

@dclayton-godaddy
Copy link
Author

They will accept a back port if I submit one, however I agree that Node.js < 18 is old. Would be nice if maybe we deployed a v3 supporting only newer versions. This would help if we run into future issues with this dependency or others.

@Nixinova
Copy link
Owner

Nixinova commented Sep 9, 2025

I'm currently working on v3 at #39. I could merge this now, but it wont get released until I'm finished that set of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants