Revert "devShellTools.unstructuredDerivationInputEnv: Match passAsFile basename"

[wolfgangwalther]

This reverts commit 1cf3103 introduced in #324789.

The commit implemented a "nice to have" TODO, which ultimately causes hash differences between Lix and Nix. We can't conditionally use the convertHash builtin, because we don't have an alternative to produce the same results.

We could, alternatively, only use the fallback path with builtins.hashString "sha256" name; and keep writeTextFile, if that's desirable.

Required to do #451926.

Things done

• Confirmed that the following now returns the same hash on latest Lix and latest NIx:
  • tests.devShellTools.nixos
  • tests.devShellTools.unstructuredDerivationInputEnv
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[roberth]

So I gather Lix doesn't have that builtin. I did not expect that.
I'd prefer to deal with optional features like this through Nixpkgs config, i.e. make it conditional on config.enableConvertHash or false and then fail nicely on evaluators that don't support it. (I guess we don't want to resort to IFD)
That way we don't have the builtins?${foo} impurity, and no loss of functionality either.
It also aligns with other features including build features like ca-derivations.

[MattSturgeon]

make it conditional on config.enableConvertHash or false and then fail nicely on evaluators that don't support it.

This sounds reasonable on first glance.

I guess we can discuss more in depth on a reapply PR, for now I approve of reverting.