go-pray: init at 0.1.13

[0xzer0x]

Powerful and user-friendly command-line interface (CLI) application that helps Muslims stay on top of their daily prayers. With features like prayer time notifications, prayer calendars, and flexible configuration options.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[yzx9]

Welcome to nixpkgs! 👋 Thanks for your contribution.

[yzx9]

Are version.buildCommit and version.buildTime required? If not, you might want to simplify the code by embedding the version directly:

buildGoModule (finalAttrs: {
  // ...
  version = "0.1.13";
  // ...
  src = fetchFromGitHub {
    // ...
    tag = "v${finalAttrs.version}";
  // ...

[0xzer0x]

Build commit is not required but build time is required to have a value in order not to break version subcommand.

[yzx9]

I'd recommend using simplified version and a fixed timestamp 1970-01-01T00:00:00Z for better maintainability.

For ref:

nixpkgs/pkgs/by-name/zs/zs/package.nix

Lines 25 to 27 in fe460b7

	"-X=main.Version=${version}"
	"-X=main.Commit=${src.rev}"
	"-X=main.Build=1970-01-01T00:00:00+00:00"

nixpkgs/pkgs/tools/networking/ivpn/default.nix

Lines 43 to 44 in 8204ce9

	"-X github.com/ivpn/desktop-app/daemon/version._version=${version}"
	"-X github.com/ivpn/desktop-app/daemon/version._time=1970-01-01"

[0xzer0x]

Agreed, I used SOURCE_DATE_EPOCH variable for the build time.

[yzx9]

And, please squash the commits to:

• maintainers: add _0xzer0x
• go-pray: init at 0.1.13

[SuperSandro2000]

Suggested change

	alsa-lib
	installShellFiles
	];
	installShellFiles
	];
	buildInputs = [
	alsa-lib
	];

wait, alsa-lib is already in buildInputs below. Why do we need both? is there an alsa-config script or so?

also lets keep the inputs together

[0xzer0x]

Thanks for pointing this out, I removed it from the nativeBuildInputs but I require it as a runtime dependency so I will have to leave it in buildInputs.

[SuperSandro2000]

Suggested change

	"-X github.com/0xzer0x/go-pray/internal/version.version=${finalAttrs.version}"
	];
	preBuild = ''
	ldflags+=" -X github.com/0xzer0x/go-pray/internal/version.buildTime=$(date -u -d "@$SOURCE_DATE_EPOCH" "+%Y-%m-%dT%H:%M:%SZ")"
	'';
	"-X github.com/0xzer0x/go-pray/internal/version.version=${finalAttrs.version}"
	"-X github.com/0xzer0x/go-pray/internal/version.buildTime=1980-01-01T00:00:00Z"
	];

lets make this simple

[SuperSandro2000]

Suggested change

buildInputs = [ alsa-lib ];