Skip to content

nemorosa: init at 0.2.0 #451915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

nemorosa: init at 0.2.0 #451915

wants to merge 3 commits into from
+147 −0

Conversation

ambroisie
Copy link
Contributor

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

ambroisie
ambroisie commented Oct 14, 2025
View reviewed changes
Sigmanificient
Sigmanificient requested changes Oct 14, 2025
View reviewed changes
pkgs/by-name/ne/nemorosa/package.nix
meta = {
description = "Specialized cross-seeding tool designed for music torrents";
homepage = "https://github.com/KyokoMiki/nemorosa";
changelog = "https://github.com/KyokoMiki/nemorosa/releases";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
changelog = "https://github.com/KyokoMiki/nemorosa/releases";
changelog = "https://github.com/KyokoMiki/nemorosa/releases/${version}";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to disagree on "changelog should point to a specific version", hence pointing to the list of releases.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Oct 14, 2025
@nix-owners nix-owners bot requested a review from natsukium October 14, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natsukium natsukium Awaiting requested review from natsukium

@Sigmanificient Sigmanificient Awaiting requested review from Sigmanificient

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ambroisie @Sigmanificient