Skip to content

rofi-file-browser: fix cmake 4 compatiblity #451728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

rofi-file-browser: fix cmake 4 compatiblity #451728

merged 1 commit into from
Oct 14, 2025
+22 −0

Conversation

bobvanderlinden
Copy link
Member

@bobvanderlinden bobvanderlinden commented Oct 13, 2025 •
edited
Loading

Things done

This adds a patch for rofi-file-browser to fix cmake4 compatiblity as tracked in #445447.
I've also submitted the patch upstream: marvinkreis/rofi-file-browser-extended#60

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@bobvanderlinden
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451728
Commit: dfe1b10b1d621a888c53c3e47acde7b74f060160

x86_64-linux

✅ 1 package built:
  • rofi-file-browser

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 13, 2025
@nix-owners nix-owners bot requested review from bew and jluttine October 13, 2025 17:18
@Sigmanificient Sigmanificient mentioned this pull request Oct 14, 2025
Open
@leona-ya leona-ya added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit abc9f7a Oct 14, 2025
33 of 36 checks passed
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leona-ya leona-ya leona-ya approved these changes

@bew bew Awaiting requested review from bew

@jluttine jluttine Awaiting requested review from jluttine

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobvanderlinden @leona-ya