Skip to content

Conversation

@xiaoxiangmoe
Copy link
Contributor

@xiaoxiangmoe xiaoxiangmoe commented Oct 4, 2025

fixes #339576

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 4, 2025
@nix-owners nix-owners bot requested a review from dotlambda October 4, 2025 17:19
@dotlambda
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 448577 --additional-package nixosTests.vaultwarden
Commit: 4af05f918e6ca929dbce6d588e722d3045ce2a93


x86_64-linux

❌ 1 package failed to build:
  • nixosTests.vaultwarden.sqlite-backup
✅ 3 tests built:
  • nixosTests.vaultwarden.mysql
  • nixosTests.vaultwarden.postgresql
  • nixosTests.vaultwarden.sqlite
✅ 1 package built:
  • bitwarden-cli

Error logs: `x86_64-linux`
nixosTests.vaultwarden.sqlite-backup
server # [   56.763720] systemd[1]: Finished Backup vaultwarden.
(finished: subtest: Run the backup script, in 0.30 seconds)
subtest: Check that backup exists
server: must succeed: [ -d "/srv/backups/vaultwarden" ]
server: (finished: must succeed: [ -d "/srv/backups/vaultwarden" ], in 0.04 seconds)
server: must succeed: [ -f "/srv/backups/vaultwarden/db.sqlite3" ]
server: (finished: must succeed: [ -f "/srv/backups/vaultwarden/db.sqlite3" ], in 0.05 seconds)
server: must succeed: [ -d "/srv/backups/vaultwarden/attachments" ]
server: output: 
!!! Test "Check that backup exists" failed with error: "command `[ -d "/srv/backups/vaultwarden/attachments" ]` failed (exit code 1)"
!!! Traceback (most recent call last):
!!!   File "<string>", line 14, in <module>
!!!     server.succeed('[ -d "/srv/backups/vaultwarden/attachments" ]')
!!! 
!!! RequestedAssertionFailed: command `[ -d "/srv/backups/vaultwarden/attachments" ]` failed (exit code 1)
cleanup
kill machine (pid 11)
qemu-system-x86_64: terminating on signal 15 from pid 8 (/nix/store/62fdlzq1x1ak2lsxp4ij7ip5k9nia3hc-python3-3.13.7/bin/python3.13)
kill vlan (pid 9)
(finished: cleanup, in 0.01 seconds)

@dotlambda dotlambda added this pull request to the merge queue Oct 7, 2025
Merged via the queue into NixOS:master with commit e83c6fc Oct 7, 2025
28 of 32 checks passed
@dotlambda dotlambda added the backport release-25.05 Backport PR automatically label Oct 16, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Oct 16, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-448577-to-release-25.05 origin/release-25.05
cd .worktree/backport-448577-to-release-25.05
git switch --create backport-448577-to-release-25.05
git cherry-pick -x 299202371c1b84c86ac6e57c9bcc5a75b572af1b 4af05f918e6ca929dbce6d588e722d3045ce2a93

@dotlambda dotlambda added backport release-25.05 Backport PR automatically and removed backport release-25.05 Backport PR automatically labels Oct 16, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Oct 16, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Oct 16, 2025
@dotlambda
Copy link
Member

@xiaoxiangmoe Would you mind filing your lock file patch as an upstream PR? Mention bitwarden/clients#16234 in that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. backport release-25.05 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: bitwarden-cli

2 participants