Skip to content

Conversation

ghpzin
Copy link
Contributor

@ghpzin ghpzin commented Sep 26, 2025

  • add patch from fedora fixing incompatible-pointer-types errors.

Fixes build failure with gcc15:

sqlite3odbc.c:4521:24: error: assignment to 'void (*)(void)'
from incompatible pointer type 'void (*)(char **)' [-Wincompatible-pointer-types]
 4521 |             s->rowfree = freerows;
      |                        ^
sqlite3odbc.c:2185:1: note: 'freerows' declared here
 2185 | freerows(char **rowp)
      | ^~~~~~~~
sqlite3odbc.c: In function 'drvtableprivileges':
sqlite3odbc.c:6173:24: error: assignment to 'void (*)(void)'
from incompatible pointer type 'void (*)(char **)' [-Wincompatible-pointer-types]
 6173 |             s->rowfree = sqlite3_free_table;
      |                        ^
In file included from sqlite3odbc.h:49,
                 from sqlite3odbc.c:25:
/nix/store/w3ibvzff0yrpg8abrl8n2fxn0d9fpfpc-sqlite-3.50.2-dev/include/sqlite3.h:3144:17:
note: 'sqlite3_free_table' declared here
 3144 | SQLITE_API void sqlite3_free_table(char **result);
      |                 ^~~~~~~~~~~~~~~~~~
sqlite3odbc.c: In function 'drvprimarykeys':
sqlite3odbc.c:6593:16: error: assignment to 'void (*)(void)' from
incompatible pointer type 'void (*)(char **)' [-Wincompatible-pointer-types]
 6593 |     s->rowfree = freerows;
      |                ^

Tested build with:

nix-build --expr 'with import ./. {}; unixODBCDrivers.sqlite.override { stdenv = gcc15Stdenv; }'

Part of fixes for gcc15 update:
#440456

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Sep 26, 2025
@ghpzin ghpzin changed the base branch from master to staging September 26, 2025 12:31
@nixpkgs-ci nixpkgs-ci bot closed this Sep 26, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Sep 26, 2025
- add patch from fedora fixing incompatible-pointer-types errors.

Fixes build failure with gcc15:
```
sqlite3odbc.c:4521:24: error: assignment to 'void (*)(void)'
from incompatible pointer type 'void (*)(char **)' [-Wincompatible-pointer-types]
 4521 |             s->rowfree = freerows;
      |                        ^
sqlite3odbc.c:2185:1: note: 'freerows' declared here
 2185 | freerows(char **rowp)
      | ^~~~~~~~
sqlite3odbc.c: In function 'drvtableprivileges':
sqlite3odbc.c:6173:24: error: assignment to 'void (*)(void)'
from incompatible pointer type 'void (*)(char **)' [-Wincompatible-pointer-types]
 6173 |             s->rowfree = sqlite3_free_table;
      |                        ^
In file included from sqlite3odbc.h:49,
                 from sqlite3odbc.c:25:
/nix/store/w3ibvzff0yrpg8abrl8n2fxn0d9fpfpc-sqlite-3.50.2-dev/include/sqlite3.h:3144:17:
note: 'sqlite3_free_table' declared here
 3144 | SQLITE_API void sqlite3_free_table(char **result);
      |                 ^~~~~~~~~~~~~~~~~~
sqlite3odbc.c: In function 'drvprimarykeys':
sqlite3odbc.c:6593:16: error: assignment to 'void (*)(void)' from
incompatible pointer type 'void (*)(char **)' [-Wincompatible-pointer-types]
 6593 |     s->rowfree = freerows;
      |                ^
```
@ghpzin ghpzin force-pushed the pr-unixodbcdrivers-sqlite-gcc15 branch from 986ca47 to 8ee1525 Compare September 26, 2025 12:32
@ghpzin ghpzin marked this pull request as ready for review September 26, 2025 12:42
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 26, 2025
@ghpzin ghpzin marked this pull request as draft September 26, 2025 12:56
@ghpzin ghpzin marked this pull request as ready for review September 26, 2025 12:57
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant