-
-
Notifications
You must be signed in to change notification settings - Fork 17.1k
radicle-tui: init at 0.6.0 #434081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
radicle-tui: init at 0.6.0 #434081
Conversation
9e514c0 to
4ad0c66
Compare
This comment was marked as outdated.
This comment was marked as outdated.
4ad0c66 to
ee7754d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
8a51bc4 to
10d75da
Compare
|
I feel that there's pretty much interest in this PR 😆 |
This comment was marked as outdated.
This comment was marked as outdated.
|
I think we should propagate |
What do you mean by propagate? Do you mean |
No, propagate it. If you install |
|
Is there any reason you are not using https://github.com/radicle-dev/radicle-tui? |
0cc302a to
b31094e
Compare
For fetching sources? No. I just figured that dog-fooding is better 😆 |
Looks like the GitHub forge is a mirror. Do you know which one is the "real" upstream? |
This comment was marked as outdated.
This comment was marked as outdated.
f1633b5 to
7088023
Compare
|
Does passthru.updateScript = nix-update-script { }; |
I honestly don't know 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set the build environment variables according to https://app.radicle.xyz/nodes/seed.radicle.xyz/rad:z39mP9rQAaGmERfUMPULfPUi473tY/tree/build.rs
You might also want to add the versionCheckHook
I don't think this would work with $ ./result/bin/rad-tui --version
rad 1.2.1 (29043134a361aa8931cd069a1c72e3d2e8deae97) |
Hm, according to their readme, |
|
I've lost track on what to do here and what not. I just wanted to get |
|
I still have a few changes locally, I can push them later today |
|
@matthiasbeyer I pushed some suggestions, feel free to squash into your commit. If #434360 is accepted before this one is merged, I would use that one and simplify the update script a bit. |
e5bc1bb to
2514226
Compare
|
👍 |
This comment was marked as outdated.
This comment was marked as outdated.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits, otherwise LGTM.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Co-authored-by: Felix Bargfeldt <41747605+Defelo@users.noreply.github.com> Co-authored-by: Yiyu Zhou <yiyuzhou19@gmail.com>
56fd5b9 to
342d1b0
Compare
|
|
I'll merge this now, right? |
Just FYI: The real upstream is rad:z39mP9rQAaGmERfUMPULfPUi473tY which you can view via the web for example at https://app.radicle.xyz/nodes/iris.radicle.xyz/rad:z39mP9rQAaGmERfUMPULfPUi473tY The GitHub repository is a mirror and might be out of date (as it currently is). cc @erak |
|
Big thanks to everyone involved! ❤️ |
Thanks for the reminder 👍 |
I did not yet fully understand how the checkout process here works, so this fails to check out the 0.6.0 tag.
Maybe someone with knowledge of radicle can help? @lorenzleutgeb maybe 😆 ?
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.