Skip to content

Conversation

@matthiasbeyer
Copy link
Contributor

I did not yet fully understand how the checkout process here works, so this fails to check out the 0.6.0 tag.

Maybe someone with knowledge of radicle can help? @lorenzleutgeb maybe 😆 ?

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@matthiasbeyer matthiasbeyer marked this pull request as draft August 15, 2025 21:28
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 15, 2025
@matthiasbeyer matthiasbeyer marked this pull request as ready for review August 16, 2025 10:30
@matthiasbeyer

This comment was marked as outdated.

@matthiasbeyer

This comment was marked as outdated.

@matthiasbeyer matthiasbeyer force-pushed the add-radicle-tui branch 2 times, most recently from 8a51bc4 to 10d75da Compare August 16, 2025 11:20
@matthiasbeyer
Copy link
Contributor Author

I feel that there's pretty much interest in this PR 😆

@matthiasbeyer

This comment was marked as outdated.

@matthiasbeyer
Copy link
Contributor Author

I think we should propagate radicle-node here, as radicle-tui/rad-tui is a replacement for the rad command, which forwards calls to rad... so there's no point in having rad-tui without rad, is there?

@yzhou216
Copy link
Contributor

I think we should propagate radicle-node here, as radicle-tui/rad-tui is a replacement for the rad command, which forwards calls to rad... so there's no point in having rad-tui without rad, is there?

What do you mean by propagate? Do you mean radicle-node as a dependency of radicle-tui?

@matthiasbeyer
Copy link
Contributor Author

What do you mean by propagate? Do you mean radicle-node as a dependency of radicle-tui?

No, propagate it. If you install radical-tui you automatically get radicale-node, because running the former without the latter does not work.

@yzhou216
Copy link
Contributor

Is there any reason you are not using https://github.com/radicle-dev/radicle-tui?

@matthiasbeyer
Copy link
Contributor Author

Is there any reason you are not using https://github.com/radicle-dev/radicle-tui?

For fetching sources? No. I just figured that dog-fooding is better 😆

@yzhou216
Copy link
Contributor

Is there any reason you are not using https://github.com/radicle-dev/radicle-tui?

For fetching sources? No. I just figured that dog-fooding is better 😆

Looks like the GitHub forge is a mirror. Do you know which one is the "real" upstream?

@matthiasbeyer

This comment was marked as outdated.

@yzhou216
Copy link
Contributor

Does nix-update-script work for fetchgit? Can't remember, but if so, you should prob add:

  passthru.updateScript = nix-update-script { };

@matthiasbeyer
Copy link
Contributor Author

Does nix-update-script work for fetchgit? Can't remember, but if so, you should prob add:

  passthru.updateScript = nix-update-script { };

I honestly don't know 😢

Copy link
Member

@Defelo Defelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the build environment variables according to https://app.radicle.xyz/nodes/seed.radicle.xyz/rad:z39mP9rQAaGmERfUMPULfPUi473tY/tree/build.rs

You might also want to add the versionCheckHook

@yzhou216
Copy link
Contributor

You might also want to add the versionCheckHook

I don't think this would work with versionCheckHook:

$ ./result/bin/rad-tui --version
rad 1.2.1 (29043134a361aa8931cd069a1c72e3d2e8deae97)

@Defelo
Copy link
Member

Defelo commented Aug 16, 2025

You might also want to add the versionCheckHook

I don't think this would work with versionCheckHook:

$ ./result/bin/rad-tui --version
rad 1.2.1 (29043134a361aa8931cd069a1c72e3d2e8deae97)

Hm, according to their readme, --no-forward should work

@matthiasbeyer
Copy link
Contributor Author

I've lost track on what to do here and what not. I just wanted to get radicle-tui into nixpkgs... please CC me with patches and I am happy to apply them to this PR (and rebase when we're finished here), but I lost track what is to do and what not. 😆

@Defelo
Copy link
Member

Defelo commented Aug 17, 2025

I still have a few changes locally, I can push them later today

@Defelo
Copy link
Member

Defelo commented Aug 17, 2025

@matthiasbeyer I pushed some suggestions, feel free to squash into your commit. If #434360 is accepted before this one is merged, I would use that one and simplify the update script a bit.

@matthiasbeyer
Copy link
Contributor Author

👍

@Defelo

This comment was marked as outdated.

@Defelo
Copy link
Member

Defelo commented Aug 17, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 434081
Commit: 56fd5b95de95099ba8b5a5745f36887f5f714bae (subsequent changes)
Merge: 681aaf18b32cc7853a1d0670d1a7f5df68156ffa

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/17023986493

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-434081-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/vsywlwp8z8hhl5i5dfgbaszvrfx3z949-radicle-tui-0.6.0
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-434081-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/gan9xzhk2ivpychdbrri1jfpqwwfvsrq-radicle-tui-0.6.0
  • aarch64-darwin
    nix-store -r --add-root nixpkgs-pr-434081-aarch64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/ddq10ipr53pjsyj6lhz3r7yyq071dxnx-radicle-tui-0.6.0

x86_64-linux

✅ 1 package built:
  • radicle-tui

aarch64-linux

✅ 1 package built:
  • radicle-tui

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • radicle-tui

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • radicle-tui

Copy link
Contributor

@yzhou216 yzhou216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits, otherwise LGTM.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 17, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 17, 2025
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Co-authored-by: Felix Bargfeldt <41747605+Defelo@users.noreply.github.com>
Co-authored-by: Yiyu Zhou <yiyuzhou19@gmail.com>
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Aug 18, 2025
@lorenzleutgeb
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 434081

Logs: https://github.com/lorenzleutgeb/nixpkgs-review-gha/actions/runs/17034352141


x86_64-linux (sandbox = true)

✅ 1 package built:
  • radicle-tui

aarch64-linux (sandbox = true)

✅ 1 package built:
  • radicle-tui

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • radicle-tui

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • radicle-tui

@matthiasbeyer
Copy link
Contributor Author

I'll merge this now, right?

@lorenzleutgeb
Copy link
Member

lorenzleutgeb commented Aug 18, 2025

Is there any reason you are not using https://github.com/radicle-dev/radicle-tui?

For fetching sources? No. I just figured that dog-fooding is better 😆

Looks like the GitHub forge is a mirror. Do you know which one is the "real" upstream?

Just FYI: The real upstream is rad:z39mP9rQAaGmERfUMPULfPUi473tY which you can view via the web for example at https://app.radicle.xyz/nodes/iris.radicle.xyz/rad:z39mP9rQAaGmERfUMPULfPUi473tY

The GitHub repository is a mirror and might be out of date (as it currently is).

cc @erak

@matthiasbeyer matthiasbeyer merged commit f8aa308 into NixOS:master Aug 18, 2025
27 of 29 checks passed
@matthiasbeyer
Copy link
Contributor Author

Big thanks to everyone involved! ❤️

@matthiasbeyer matthiasbeyer deleted the add-radicle-tui branch August 18, 2025 09:57
@erak
Copy link

erak commented Aug 19, 2025

Is there any reason you are not using https://github.com/radicle-dev/radicle-tui?

For fetching sources? No. I just figured that dog-fooding is better 😆

Looks like the GitHub forge is a mirror. Do you know which one is the "real" upstream?

Just FYI: The real upstream is rad:z39mP9rQAaGmERfUMPULfPUi473tY which you can view via the web for example at https://app.radicle.xyz/nodes/iris.radicle.xyz/rad:z39mP9rQAaGmERfUMPULfPUi473tY

The GitHub repository is a mirror and might be out of date (as it currently is).

cc @erak

Thanks for the reminder 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants