Skip to content

stdenv.mkDerivation: support mainProgram as a top‐level attribute #430810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: staging
Choose a base branch
from
Draft

stdenv.mkDerivation: support mainProgram as a top‐level attribute #430810

wants to merge 2 commits into from
+33 −17

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Aug 4, 2025

See #412768 (comment) for context. Totally untested, needs docs, could be a bikeshed magnet, would need eventual follow‐up with a tree‐wide and staged warnings/errors, etc., but putting it out there. This would also currently break versionCheckHook’s default for any non‐migrated package, so we’d have to decide whether we want to pull it in as a full attribute for compatibility for now, or else couple reducing use of the pname default to lifting mainProgram out. Also if this eventually gets merged and I see people bikeshedding about moving it in unrelated PRs rather than automating it I’ll lose it.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy requested a review from adisbladis August 4, 2025 02:43
@emilazy emilazy marked this pull request as draft August 4, 2025 02:43
@emilazy emilazy requested review from a team and bengsparks August 4, 2025 02:43
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: stdenv Standard environment 6.topic: lib The Nixpkgs function library labels Aug 4, 2025
@acid-bong

This comment was marked as outdated.

Sign in to view
@alyssais
Copy link
Member

alyssais commented Aug 4, 2025

Ack

@emilazy

This comment was marked as outdated.

Sign in to view
@acid-bong

This comment was marked as outdated.

Sign in to view
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 4, 2025
philiptaron
philiptaron approved these changes Aug 28, 2025
View reviewed changes
pkgs/stdenv/generic/check-meta.nix
]
++ optional (hasOutput "man") "man";
}
// optionalAttrs (attrs ? mainProgram) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pull the same trick as #430969 here too.

@github-project-automation github-project-automation bot moved this to In Progress in Stdenv Aug 28, 2025
@philiptaron
Copy link
Contributor

if this eventually gets merged and I see people bikeshedding about moving it in unrelated PRs rather than automating it I’ll lose it.

You know it'll happen. We have #297084 and @stuebinm to show that the better world is possible.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 28, 2025
@emilazy emilazy mentioned this pull request Oct 21, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philiptaron philiptaron philiptaron approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@bengsparks bengsparks Awaiting requested review from bengsparks

@hsjobeki hsjobeki Awaiting requested review from hsjobeki

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@reckenrode reckenrode Awaiting requested review from reckenrode

@alyssais alyssais Awaiting requested review from alyssais

@Artturin Artturin Awaiting requested review from Artturin

@infinisil infinisil Awaiting requested review from infinisil

@RossComputerGuy RossComputerGuy Awaiting requested review from RossComputerGuy

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: lib The Nixpkgs function library 6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

Stdenv
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emilazy @acid-bong @alyssais @philiptaron