Skip to content

Conversation

fpletz
Copy link
Member

@fpletz fpletz commented Mar 12, 2025

https://github.com/htop-dev/htop/releases/tag/3.4.0
https://github.com/htop-dev/htop/blob/3.4.0/ChangeLog

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 12, 2025
@matthiasbeyer
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389164


x86_64-linux

❌ 1 package failed to build:
  • htop-vim
✅ 1 package built:
  • htop

@matthiasbeyer matthiasbeyer merged commit b27014b into NixOS:master Mar 12, 2025
27 checks passed
@phanirithvij
Copy link
Member

phanirithvij commented Mar 12, 2025

htop-vim is broken, why the hurry

Edit: okay nevermind, that is not a plugin or so like I assumed, it is a fork. maybe it should be removed then?

@fpletz fpletz deleted the pkgs/htop-3.4.0 branch March 12, 2025 17:42
@SuperSandro2000
Copy link
Member

feel free to open a PR to mark it broken

@fpletz
Copy link
Member Author

fpletz commented Mar 13, 2025

Opened a PR upstream to get rid of our patching eventually: htop-dev/htop#1637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants