Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Apr 1, 2025

This PR introduces a method to create seeds instead of the regular store operation which creates secret shares. Default seed length is set to 64. In decrypt, it sorts the shares by length assuming they will either be all the same length, which means they will just be xored as before, or they will be different length, which means every share except the longest is a seed. This ensures backward compatibility as shares already uploaded would just be xored together.

@ghost ghost self-assigned this Apr 1, 2025
@ghost ghost requested a review from jimouris April 1, 2025 19:01
@coveralls
Copy link

coveralls commented Apr 1, 2025

Pull Request Test Coverage Report for Build 14227522747

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 14185699662: 0.0%
Covered Lines: 391
Relevant Lines: 391

💛 - Coveralls

@ghost ghost force-pushed the feat/seed branch from 7bf8443 to abb7415 Compare April 1, 2025 20:28
@ghost ghost force-pushed the feat/seed branch from abb7415 to f669aec Compare April 1, 2025 20:31
Copy link
Member

@jimouris jimouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for @lapets to review before merging.

@psofiterol
Copy link
Member

I just used the new/proposed nilql.py directly on secretvaults-py and run all the STORE examples, just to double check. All good 👍 .

Thanks for the heads up @jimouris 🙏

@jimouris jimouris requested a review from lapets April 2, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants