Skip to content

Conversation

@IDCs
Copy link
Contributor

@IDCs IDCs commented Nov 6, 2025

This commit is a bit more hefty than I'd like, but this was a long time coming.

  • IDownload now has proper typings (no more scouring through the code for the correct state branch for modId/fileId/gameId)
  • Fixed incorrect typings being used by mixpanel wherever the nexusIds selector was used. (highlighted by the fact that we now actually have proper damn types)
  • Added ability to generate a IModReference object reliably from an IDownload object.
  • Added selector to retrieve all finished downloads for a specific game
  • Fixed installer calls not being forwarded IInstallationDetails object correctly.

closes #18739

This commit is a bit more hefty than I'd like, but this was a long time
coming.

- IDownload now has proper typings (no more scouring through the code
  for the correct state branch for modId/fileId/gameId)
- Fixed incorrect typings being used by mixpanel wherever the nexusIds
  selector was used. (highlighted by the fact that we now actually have
  proper damn types)
- Added ability to generate a IModReference object reliably from an
  IDownload object.
- Added selector to retrieve all finished downloads for a specific game

closes #18739
@IDCs IDCs requested review from Aragas and insomnious November 6, 2025 09:00
@insomnious insomnious removed the request for review from Aragas November 6, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create an allowedlist for fomods with c# scripts

2 participants