Experimental macos #18182
Experimental macos #18182
Conversation
ErikVeland
force-pushed
the
experimental-macos
branch
from
99e45de to
ff1a6f1
Compare
|
Hey @ErikVeland just wanted to thank you for your contributions in an attempt to get a macos version of Vortex out there. We're not ignoring your PR - it's just that 200k lines of code are going to take a while to review + your contribution came in an interesting period where we're applying major refactors to the codebase and your PR is understandably trailing behind the main repo. The main refactoring is now finished and we're finally able to look at your code, however the conflicts need to be sorted out before we can test this. To add - we currently do not have a macos machine to test this on. We will be looking at fixing this fact in the near future, but will be flexible as long as it still builds and behaves as expected on Windows which is our main platform. Cheers, |
Hi Nagev, Appreciate your response. I completely understand that this a major risk to the main codebase, and that this monolithic PR will seem overwhelming. I have continued to work on the project since lodging this PR and I am planning to make more modular, incremental PRs with full documentation for each phase so that it is more understandable what each PR does and what risks it may incur. For now, just treat this as an overview of where it will touch upon - and I will try and separate as many components from the main codebase as possible (and document any possible enhancements to the main app I have discovered along the way). Thanks for your encouragement and I am looking forward to contributing! Cheers, |
- Faster resolution of existing/missing depenendencies upon initial installation of collection - Download queue is now processed every 500 msec and will inform the user of free/occupied download slots - Slow workers (no data reception in the last 5 ticks will get restarted) - Temporary errors such as EIO, ETIMEDOUT, etc will attempt to resume upon failure
Previously restarting a download had the potential of sending an additional api request, trying to resolve the url of a mod
less state manipulation, less overhead
- Improved slow worker restart functionality - Better error handling - Now prioritizing single chunk downloads over multi-chunk
- Also removed the "moved to x" notification (added debug log calls)
Also reduced download speed and update event debouncers for better user feedback on download progress
- Also added cache to avoid duplicate requests
- added proper installation queuing separate from download functionality - better installation tracking to allow for concurrent installations - now properly supports multiple concurrent installations - removed pointless dummy installation queueing
M .submodule_remotes_backup.json ?? "Balatro Vortex Extension-1315-0-1-2-1748486275/0.1.2.txt" ?? "Balatro Vortex Extension-1315-0-1-2-1748486275/CHANGELOG.md" ?? "Balatro Vortex Extension-1315-0-1-2-1748486275/balatro.jpg" ?? "Balatro Vortex Extension-1315-0-1-2-1748486275/downloader.js" ?? "Balatro Vortex Extension-1315-0-1-2-1748486275/downloader.js.map" ?? "Balatro Vortex Extension-1315-0-1-2-1748486275/index.js" ?? "Balatro Vortex Extension-1315-0-1-2-1748486275/info.json"
Not working: Game management, Game Discovery
… simplify Promise wrapper - Add 🔍 emoji to 'Checking for updates...' log - Add⚠️ emoji to warning messages for better visibility - Add ⬇️ emoji to 'Update downloaded' log - Simplify Promise wrapper around setTimeout for checkForUpdates - Retain development mode detection for safety
- Add missing macOS compatibility functions (validateCyberpunkMacOSCompatibility, hasWindowsOnlyFiles, hasWindowsOnlyDirectories, hasWindowsOnlyFrameworks) - Export MACOS_GAME_FIXES constant for gamemode management - Fix package validation by aligning dependency references with app directory - All changes tested: TypeScript compilation, build, lint, and basic functionality verified
api 8945e882f3794e6faae02ac2e2045c41617d91da 894ed1fbbe20ccc4af8fcfd6e71c82882150b2e6 extensions/common-interpreters 05592583eb86dcec3618e8036875e884d5edacb8 afd34d6af2de7c058dde9799a5a25ee28bff8d41 extensions/theme-switcher 435574faf74cac6000c429a22361b8c7634389bd cdb2b39ddeb4a821c3c045b5025452e3d561cff8
ErikVeland
force-pushed
the
experimental-macos
branch
from
c84b74d to
1d2938f
Compare
Improves compatibility with macOS by ensuring the launcher is correctly located and handled. Also, refactors promise handling and error management for more robust operation.
Theme not loading
|
Seriously impressive work, and I would love to try it out but sadly can't get it to build (user error most likely) Would you be so kind as to provide a build to play with? Even unsigned would be amazing. |
Hi Richard. It is building here at the moment, but the theme isn't working. I'm currently in the process of refactoring for Node 22 and native promises, so the app is in a bit of a flux. (Also most recently went from Electron 28 to 38 for Tahoe compatibility without the slowdown). What you are likely seeing is that it also requires all the submodules to be up to date with my forks and there's about 54 of them including the api and bundled extensions. I can provide a signed build once I get back to stable again for you to play with. |
4 participants
No description provided.