fix(morph-plot): handle files with single point cell types #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a file contains the definition of a point cell type, for example, `IafTauRefCell`, we should still be able to plot the file, even if its only a single circle/sphere. Until now, we only handled files if they had multi-compartmental `Cell` or `Morphology` instances, and the plotter would crash for files that had other point cell types.
|
TODO: add a simple regression test |
sanjayankur31
deleted the
fix-plotting-plot-all-point-cell-component-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file contains the definition of a point cell type, for example,
IafTauRefCell, we should still be able to plot the file, even if its only a single circle/sphere. Until now, we only handled files if they had multi-compartmentalCellorMorphologyinstances, and the plotter would crash for files that had other point cell types.