Skip to content

Put some stuff in block processing to background thread #9595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Put some stuff in block processing to background thread #9595

wants to merge 6 commits into from

Conversation

@LukaszRozmej
Copy link
Member

@LukaszRozmej LukaszRozmej commented Oct 29, 2025 •
edited
Loading

Changes

In background:

  • CalculateBlooms
  • CalculateBlobGas
  • GetReceiptsRoot

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • Yes

If yes, did you write tests?

  • No
image

Almost 2% of large blocks.

@LukaszRozmej
Try put in background:
bd23083 
- CalculateBlooms
- CalculateBlobGas
- GetReceiptsRoot
@LukaszRozmej
remove cancellation
37a4094
benaadams
benaadams approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@benaadams benaadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If metrics agree

@benaadams
Copy link
Member

benaadams commented Oct 31, 2025 

failed CreateEraAndVerifyAccumulators (952ms)
  Did not expect any exception, but found Nethermind.Era1.Exceptions.EraVerificationException: 
  Mismatched receipt root. Block number 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benaadams benaadams benaadams approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25 MarekM25 will be requested when the pull request is marked ready for review MarekM25 is a code owner

@flcl42 flcl42 Awaiting requested review from flcl42 flcl42 will be requested when the pull request is marked ready for review flcl42 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

performance is good

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LukaszRozmej @benaadams @kamilchodola