feature: alternate approach to environment force-rebuild #2443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
reviewed
Jun 5, 2025
metaflow/cli.py
Outdated
| @@ -242,6 +243,14 @@ def version(obj): | |||
| type=click.Choice(["local"] + [m.TYPE for m in ENVIRONMENTS]), | |||
| help="Execution environment type", | |||
| ) | |||
| @click.option( | |||
| "--force-rebuild-environment/--no-force-rebuild-environment", | |||
There was a problem hiding this comment.
can we change this to --rebuild-environments
There was a problem hiding this comment.
actually, nvm. let's keep the force, otherwise --no-rebuild-environments takes a different meaning altogether. tiny nit - --force-rebuild-environments since there can be more than one.
savingoyal
reviewed
Jun 5, 2025
metaflow/cli.py
Outdated
| default=False, | ||
| hidden=True, | ||
| type=bool, | ||
| help="Force rebuild the environment", |
There was a problem hiding this comment.
explicitly rebuild the execution environments
savingoyal
reviewed
Jun 5, 2025
metaflow/cli.py
Outdated
| @@ -432,6 +442,9 @@ def start( | |||
|
|
|||
| ctx.obj.graph = ctx.obj.flow._graph | |||
|
|
|||
| # carry the force rebuild as an internal env var for generic environments to use | |||
| if force_rebuild_environment: | |||
| os.environ["_MFENV_FORCE_REBUILD"] = "1" | |||
There was a problem hiding this comment.
_METAFLOW_ENVIRONMENT_FORCE_REBUILD? MFENV will very soon have different connotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a top-level option to toggle force-rebuilding the environment
the introduction of the new option is not mandatory. we could simply proceed with an internal envvar to enable the functionality for now.